Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys_fs: Fixed up sys_fs_fcntl(0xc0000007, 0xc0000015, and 0xc000001c) according to real hardware testing #14368

Merged
merged 2 commits into from Jul 26, 2023

Conversation

brian218
Copy link
Contributor

@brian218 brian218 commented Jul 25, 2023

I tested sys_fs_fcntl(0xc0000007) aka cellFsArcadeHddSerialNumber on my real hardware, validated the result, and compared the output values with the ones obtained from some other methods on my PC.
It turned out that padding and alignment (model: left, serial: right) are used by sys_fs_fcntl(0xc0000007) to compose the output.

Following is the information of my HDD obtained through sys_fs_fcntl(0xc0000007) for example:

Model Name: "TOSHIBA MK3265GSX H                     "
Serial Number: "           0A1B2C3D4"

Also, it seems like the syscall doesn't care about the device name in the arguments, though it's supposed to be "CELL_FS_IOS:ATA_HDD".

I also tested sys_fs_fcntl(0xc0000015&0xc000001c) on my real hardware, and it turned out the error handling was a little bit different.
Following is the testing result on the real hardware:

path="/dev_usb000": return: CELL_OK, arg->out_code: CELL_OK
path="/dev_hdd0": return: CELL_OK, arg->out_code: CELL_ENOTMOUNTED
path="/": return: CELL_OK, arg->out_code: CELL_ENOTMOUNTED
path="": return: CELL_ENOMEM, arg->out_code: CELL_OK

Utilities/StrFmt.cpp Outdated Show resolved Hide resolved
@Megamouse
Copy link
Contributor

Updated the OP. you can just mark the section as code and it will keep the strings unchanged

Utilities/StrFmt.cpp Outdated Show resolved Hide resolved
@brian218 brian218 changed the title sys_fs: Fixed up sys_fs_fcntl(0xc0000007) aka cellFsArcadeHddSerialNumber according to real hardware testing sys_fs: Fixed up sys_fs_fcntl(0xc0000007, 0xc0000015, and 0xc000001c) according to real hardware testing Jul 26, 2023
@elad335 elad335 merged commit 9a5bdc9 into RPCS3:master Jul 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants